Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TeslaFi stable to 1.1.0 #4524

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Bump TeslaFi stable to 1.1.0 #4524

merged 1 commit into from
Feb 1, 2025

Conversation

hombach
Copy link
Contributor

@hombach hombach commented Feb 1, 2025

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

Automated adapter checker

ioBroker.teslafi

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E254] Version "1.1.1" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
  • 👀 [W132] Many "common.news" found in io-package.json. Repository builder will truncate at 7 news. Please remove old news.
  • 👀 [W252] Version of package.json (1.1.1) doesn't match latest version on NPM (1.1.0)
  • 👀 [W508] attribute "xs" for staticImage should specify a value of "12" at admin/jsonConfig.json/items/_StandardTab/_donate

Adapter releases: https://www.iobroker.dev/adapter/teslafi/releases
Adapter statistic: https://www.iobroker.dev/adapter/teslafi/statistics

History and usage information for release 1.1.0:

1.1.0 created 25.1.2025 (6 days old)
6 users (54.55%)

1.0.0 (stable) created 25.12.2024 (37 days old)
4 users (stable) (36.36%)

Please verify that this PR really tries to update to release 1.1.0!

Add comment "RE-CHECK!" to start check anew

@hombach
Copy link
Contributor Author

hombach commented Feb 1, 2025

is it usefull that adapter checker isworking against GIT? It should check the Version in NPM to be released.

@github-actions github-actions bot added the *📬 a new comment has been added label Feb 1, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 1, 2025

Could be disussed but the primary goal is to check the repository BEFORE a release is deployed. Extending to get data from 2 sources could be an option but is not implemented currently.

In addition E254 must be checked against the repository anyway as repository builder uses this data. So no Phantom Versions should be conatined there as the user will be presented this version when selecting "Install specific version". Same is valid for others, i.e. W252 as the possibility that the deploy did not work cannot be detected based on npm content.

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Feb 1, 2025
@mcm1957 mcm1957 merged commit a830062 into ioBroker:master Feb 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants