Add bitaxe to latest

[Hans-Wurst-21]

Please add my adapter ioBroker.bitaxe to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

[mcm1957]

reminder 13.12.2024

[github-actions]

Automated adapter checker

ioBroker.bitaxe

-

👍 No errors found

• 👀 [W401] Cannot find "bitaxe" in latest repository

Add comment "RE-CHECK!" to start check anew

[mcm1957]

@Hans-Wurst-21

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

• UI labels seem to have no translation into all languages

  It seems that labels are not translated into all supported languages.
  Please consider adding missing translations to english translations json and run npm run translate

• Add timeout to axios calls

  All axios calls should have a timeout set. The default value for axios timeout is 0 which results in no timeout. So an unresponsive remote system could lead to an hanging adapter. Either set an appropiate timeout per axios call or set a default timeout globally for the axios instance.

• consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout

  The adapter package provides wrapper routines for native setTimeout, setInterval, clearTimeout and clearInterval. Using those routines ensures that timers are cancelled on on load. Additional checks on thomse limits might be performed, too. So consider replacing native setTimeout/clearTimeout by adapter.setTimeout/adapter.clearTimeout or this.setTimeout/this.clearTimeout. The same refers to setInterval/clearInterval.

• check and limit configurable timeouts / intervals

  Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than 2,147,483,647 ms (about 24.8 days) result in the timeout being executed immediately. So all (user configurable) values passed to setTimeout / setInterval should be checked in code and limited. Checking/limiting in code is required as config data could be changed directly or by some other adapter too, so limiting at ui level might not be sufficient.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestions or at least commented the suggestions and you think the adapter is ready for a re-review!

reminder 1.1.2025

[mcm1957]

Did you have time to review and fix the issues listed abaove? I did not receive any feedback until now. Do you need some help? Please let us know what the current status of processing is.

reminder 22.1.2025

[mcm1957]

@Hans-Wurst-21

To verify the Object structure of this adapter during RE-REVIEW please export the object structure of a working installation and attach the file in addtion to fixing or commenting the issues mentioned above. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

Thanks

[mcm1957]

@Hans-Wurst-21

Did you have time to review and fix the issues listed abaove? I did not receive any feedback until now. Do you need some help? Please let us know what the current status of processing is.

To verify the Object structure of this adapter during RE-REVIEW please export the object structure of a working installation and attach the file in addtion to fixing or commenting the issues mentioned above. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

Thanks

reminder 10.2.2025

[mcm1957]

@Hans-Wurst-21

Did you have time to review and fix the issues listed above? I did not receive any feedback until now. Do you need some help? Please let us know what the current status of processing is.

To verify the Object structure of this adapter during RE-REVIEW please export the object structure of a working installation and attach the file in addtion to fixing or commenting the issues mentioned above. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

Any reaction - even a short statement that you plan to resume work at xxx will be welcome.

If there is no reaction until 28.2.2025 this PR will be closed.

reminder 20.2.2025