Changed color name #347
Merged
Changed color name #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Apollon77
added a commit
that referenced
this pull request
Jan 25, 2025
This reverts commit bd519a5.
Apollon77
added a commit
that referenced
this pull request
Jan 25, 2025
# Conflicts: # package-lock.json # package.json
There was a problem hiding this comment.
Copilot reviewed 19 out of 34 changed files in this pull request and generated no comments.
Files not reviewed (15)
- package.json: Language not supported
- src-admin/package-lock.json: Language not supported
- src-admin/package.json: Language not supported
- src-admin/src/i18n/de.json: Language not supported
- src-admin/src/i18n/en.json: Language not supported
- src-admin/src/i18n/es.json: Language not supported
- src-admin/src/i18n/fr.json: Language not supported
- src-admin/src/i18n/it.json: Language not supported
- src-admin/src/i18n/nl.json: Language not supported
- src-admin/src/i18n/pl.json: Language not supported
- src-admin/src/i18n/pt.json: Language not supported
- src-admin/src/i18n/ru.json: Language not supported
- src-admin/src/i18n/uk.json: Language not supported
- src-admin/src/i18n/zh-cn.json: Language not supported
- src/lib/i18n/de.json: Language not supported
Comments suppressed due to low confidence (4)
src-admin/src/App.tsx:787
- The translation string 'Identifying device %s' may lead to unclear error messages if the translation is not properly handled. Ensure that the translation is clear and helpful.
message={<span>{I18n.t(`Identifying device %s`, name)}</span>}
src-admin/src/App.tsx:778
- Using 'open={!0}' is unconventional and could be replaced with 'open={true}' for better readability.
open={!0}
src-admin/src/Tabs/BridgesAndDevices.tsx:63
- Changing the type from React.CSSProperties to any can introduce ambiguity and potential bugs. Consider using a more specific type.
export const STYLES: Record<string, any> = {
src-admin/src/Tabs/BridgesAndDevices.tsx:531
- The return type Record<string, any> is ambiguous. Consider using a more specific type.
getBlinkingSx(uuid: string): Record<string, any> | undefined {
* (@GermanBluefox) Implemented the identify popup in GUI
Apollon77
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.