Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not require restart when changing controller settings #31

Merged
merged 8 commits into from
Jul 9, 2024
Merged

do not require restart when changing controller settings #31

merged 8 commits into from
Jul 9, 2024

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented Jul 7, 2024 •
edited
Loading

Applied the new workflow to controller settings

  • Do not show save button on controller tab
  • On changes we send a message to the backend
  • Backend saves config after validating
  • During backend processing we show an overlay with a loading spinner
  • Bluetooth settings have been moved to a dialog

@foxriver76 foxriver76 marked this pull request as ready for review July 9, 2024 10:05
Apollon77 added 2 commits July 9, 2024 12:14
@Apollon77
Revert object subscribe
e842052 
.. till logic is verified that would be executed now
@Apollon77
Syync message response
01c32aa
Apollon77
Apollon77 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not really review the react stuff, but we can iterate on it

@Apollon77 Apollon77 merged commit 11944bb into main Jul 9, 2024
2 checks passed
@foxriver76 foxriver76 deleted the config-no-restart branch July 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollon77 Apollon77 Apollon77 approved these changes

@GermanBluefox GermanBluefox Awaiting requested review from GermanBluefox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foxriver76 @Apollon77