Feature/core changes #245

martinfalk · 2024-12-10T12:11:26Z

No description provided.

github-actions · 2024-12-10T12:22:22Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v17.0.6) reports: 10 concern(s)

misc/vtk/include/inviwo/vtk/ports/vtkinport.h:31:10: error: [clang-diagnostic-error]

'inviwo/vtk/vtkmoduledefine.h' file not found
```
   31 | #include <inviwo/vtk/vtkmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
misc/vtk/include/inviwo/vtk/ports/vtkoutport.h:31:10: error: [clang-diagnostic-error]

'inviwo/vtk/vtkmoduledefine.h' file not found
```
   31 | #include <inviwo/vtk/vtkmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/datastructures/contourtreedata.h:31:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   31 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/datastructures/morsesmalecomplexdata.h:31:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   31 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/datastructures/triangulationdata.h:33:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   33 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/ports/persistencediagramport.h:33:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   33 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/properties/topologycolorsproperty.h:31:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   31 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/include/inviwo/topologytoolkit/properties/topologyfilterproperty.h:31:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/topologytoolkitmoduledefine.h' file not found
```
   31 | #include <inviwo/topologytoolkit/topologytoolkitmoduledefine.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/src/properties/topologycolorsproperty.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/properties/topologycolorsproperty.h' file not found
```
   30 | #include <inviwo/topologytoolkit/properties/topologycolorsproperty.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
topovis/topologytoolkit/src/properties/topologyfilterproperty.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/topologytoolkit/properties/topologyfilterproperty.h' file not found
```
   30 | #include <inviwo/topologytoolkit/properties/topologyfilterproperty.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v17.0.6

Click here for the full clang-tidy patch

diff --git a/misc/graphviz/src/graphvizsettings.cpp b/misc/graphviz/src/graphvizsettings.cpp
index d7d1a69..dab66af 100644
--- a/misc/graphviz/src/graphvizsettings.cpp
+++ b/misc/graphviz/src/graphvizsettings.cpp
@@ -247 +247 @@ void GraphvizSettings::onProcessorNetworkDidAddProcessor(Processor* processor) {
-    auto meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
+    auto* meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
@@ -252 +252 @@ void GraphvizSettings::onProcessorNetworkDidRemoveProcessor(Processor* processor
-    auto meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
+    auto* meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
diff --git a/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h b/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
index e78ccbd..ff0a942 100644
--- a/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
+++ b/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
@@ -43 +43 @@ struct DataTraits<molvis::MolecularStructure> {
-    static constexpr uvec3 colorCode() { return uvec3(56, 127, 66); }
+    static constexpr uvec3 colorCode() { return {56, 127, 66}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
index 4c086f1..dd029d7 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
@@ -183 +183 @@ struct DataTraits<InvariantSpace> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 235); }
+    static constexpr uvec3 colorCode() { return {10, 150, 235}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
index 5c26da6..314eebb 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
@@ -177 +177 @@ struct DataTraits<TensorField2D> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 135); }
+    static constexpr uvec3 colorCode() { return {10, 150, 135}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
index cd32d28..e086cb2 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
@@ -362 +362 @@ struct DataTraits<TensorField3D> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 135); }
+    static constexpr uvec3 colorCode() { return {10, 150, 135}; }

Have any feedback or feature suggestions? Share it here.

misc/graphviz/src/graphvizsettings.cpp

molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v17.0.6

Click here for the full clang-tidy patch

diff --git a/misc/graphviz/src/graphvizsettings.cpp b/misc/graphviz/src/graphvizsettings.cpp
index d7d1a69..dab66af 100644
--- a/misc/graphviz/src/graphvizsettings.cpp
+++ b/misc/graphviz/src/graphvizsettings.cpp
@@ -247 +247 @@ void GraphvizSettings::onProcessorNetworkDidAddProcessor(Processor* processor) {
-    auto meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
+    auto* meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
@@ -252 +252 @@ void GraphvizSettings::onProcessorNetworkDidRemoveProcessor(Processor* processor
-    auto meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
+    auto* meta = processor->getMetaData<ProcessorMetaData>(ProcessorMetaData::classIdentifier);
diff --git a/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h b/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
index e78ccbd..ff0a942 100644
--- a/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
+++ b/molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h
@@ -43 +43 @@ struct DataTraits<molvis::MolecularStructure> {
-    static constexpr uvec3 colorCode() { return uvec3(56, 127, 66); }
+    static constexpr uvec3 colorCode() { return {56, 127, 66}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
index 4c086f1..dd029d7 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h
@@ -183 +183 @@ struct DataTraits<InvariantSpace> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 235); }
+    static constexpr uvec3 colorCode() { return {10, 150, 235}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
index 5c26da6..314eebb 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h
@@ -177 +177 @@ struct DataTraits<TensorField2D> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 135); }
+    static constexpr uvec3 colorCode() { return {10, 150, 135}; }
diff --git a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
index cd32d28..e086cb2 100644
--- a/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
+++ b/tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h
@@ -362 +362 @@ struct DataTraits<TensorField3D> {
-    static constexpr uvec3 colorCode() { return uvec3(10, 150, 135); }
+    static constexpr uvec3 colorCode() { return {10, 150, 135}; }

Have any feedback or feature suggestions? Share it here.

misc/graphviz/src/graphvizsettings.cpp

molvis/molvisbase/include/inviwo/molvisbase/datastructures/molecularstructuretraits.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/invariantspace.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield2d.h

tensorvis/tensorvisbase/include/inviwo/tensorvisbase/datastructures/tensorfield3d.h

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v17.0.6

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v17.0.6

Click here for the full clang-tidy patch

diff --git a/misc/openmesh/src/utils/openmeshconverters.cpp b/misc/openmesh/src/utils/openmeshconverters.cpp
index 8016e44..6fba52e 100644
--- a/misc/openmesh/src/utils/openmeshconverters.cpp
+++ b/misc/openmesh/src/utils/openmeshconverters.cpp
@@ -198 +198 @@ TriMesh fromInviwo(const Mesh& inmesh, TransformCoordinates transform) {
-    } else if (auto sm = dynamic_cast<const SimpleMesh*>(&inmesh)) {
+    } else if (const auto* sm = dynamic_cast<const SimpleMesh*>(&inmesh)) {

Have any feedback or feature suggestions? Share it here.

misc/openmesh/src/utils/openmeshconverters.cpp

misc/openmesh/include/inviwo/openmesh/utils/openmeshconverters.h

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v17.0.6

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

petersteneteg and others added 2 commits December 10, 2024 13:09

Various: updates for core changes

61c5da7

TensorVis: updates for core changes

fda9a79

martinfalk requested a review from petersteneteg December 10, 2024 12:11

github-actions bot previously requested changes Dec 10, 2024

View reviewed changes

Various: update for core changes

d381df6

github-actions bot previously requested changes Dec 10, 2024

View reviewed changes

MolVis,Misc,TensorVis: linter

5be8bb3

Inviwo-Team added J: Format Test Failure J: Build Failure labels Dec 11, 2024

github-actions bot previously approved these changes Dec 11, 2024

View reviewed changes

OpenMesh: compile fix

983dd82

martinfalk force-pushed the feature/core-changes branch from 9b6dd59 to 983dd82 Compare December 11, 2024 11:32

github-actions bot previously requested changes Dec 11, 2024

View reviewed changes

misc/openmesh/src/utils/openmeshconverters.cpp Outdated Show resolved Hide resolved

petersteneteg approved these changes Dec 11, 2024

View reviewed changes

misc/openmesh/include/inviwo/openmesh/utils/openmeshconverters.h Outdated Show resolved Hide resolved

martinfalk removed the J: Format Test Failure label Dec 11, 2024

VTK,TopologyToolkit: clang format

d9aaa70

This comment was marked as outdated.

Sign in to view

OpenMesh: requested changes

f511e4d

martinfalk force-pushed the feature/core-changes branch from cada059 to f511e4d Compare December 11, 2024 16:42

martinfalk removed the J: Build Failure label Dec 11, 2024

Inviwo-Team added the J: Build Failure label Dec 11, 2024

github-actions bot approved these changes Dec 11, 2024

View reviewed changes

petersteneteg approved these changes Dec 11, 2024

View reviewed changes

martinfalk merged commit 8d374c1 into master Dec 12, 2024
14 of 16 checks passed

martinfalk deleted the feature/core-changes branch December 12, 2024 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/core changes #245

Feature/core changes #245

martinfalk commented Dec 10, 2024

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

This comment was marked as outdated.

github-actions bot left a comment

Feature/core changes #245

Feature/core changes #245

Conversation

martinfalk commented Dec 10, 2024

github-actions bot commented Dec 10, 2024 • edited Loading

Cpp-Linter Report ⚠️

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v17.0.6

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v17.0.6

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v17.0.6

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v17.0.6

This comment was marked as outdated.

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v17.0.6

github-actions bot commented Dec 10, 2024 •

edited

Loading