Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yara forge analyzer #2589

Conversation

decodingafterlife
Copy link

YARA Forge Analyzer #2035

Description

Added yara forge analyzer

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@mlodic
Copy link
Member

mlodic commented Dec 5, 2024

hey, thanks for the interesting in the project. Please do not remove part of the PR checklist, we use it to understand the status of the PR.

About the PR, please follow through the documentation about how to create a new analyzer. For this task, you don't need to create a docker integration, that is over-engineering the problem. A classic analyzer would make its work.

'matches': matches
})
except Exception as e:
return jsonify({'error': str(e)}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
@decodingafterlife
Copy link
Author

decodingafterlife commented Dec 8, 2024

Sorry my bad, I'll do it as a normal analyzer. I have university exams going on so I'll need some time (15 days) before I can get back to this.

@mlodic
Copy link
Member

mlodic commented Dec 9, 2024

np @decodingafterlife! We are happy to have you here!

@mlodic
Copy link
Member

mlodic commented Dec 19, 2024

I'll close this due to the imminent new release and due to the fact that the approach was incorrect.

This task must be addresses together with the Yara-X issue. See #2035 for updates

@mlodic mlodic closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants