This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
implement sink IDRRequest handling #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,6 +155,8 @@ class SinkMediaManager : public MediaManager { | |||
| * @return connector type. @see ConnectorType | |||
| */ | |||
| virtual ConnectorType GetConnectorType() const = 0; | |||
|
|
|||
| virtual void IDRRequestDone(bool success) = 0; | |||
There was a problem hiding this comment.
pls provide description for the newly added method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this with several devices. Two things should be noted:
I've added the IDRRequestDone() callback to be able to handle this in my application, but maybe we should prevent the second request inside libwds?