-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building System: Enable device code compression (Lin/Win) #1148
Merged
+46
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feng Yuan <[email protected]>
fengyuan14
commented
Dec 25, 2024
fengyuan14
commented
Dec 25, 2024
fengyuan14
changed the title
DONOTMERGE: Evaluate device code compression.
Building System: Enable device code compression (Lin/Win)
Dec 26, 2024
chunhuanMeng
approved these changes
Dec 26, 2024
chuanqi129
reviewed
Dec 26, 2024
cmake/BuildFlags.cmake
Outdated
else() | ||
set(AOT_TARGETS "pvc,xe-lpg,ats-m150") | ||
set(AOT_TARGETS "pvc,xe-lpg,dg2-g10,xe2-lpg,xe2-hpg") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed before, let's remove BMG in default linux aot target. Because we have LTS driver for linux server gpu, it will break the build on LTS driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage to align binary distribution with CUDA. That is only
libtorch_cuda.so
at all. The first stage helps on combining all kernel libraries into one. After the commit, we will have two librarieslibtorch_xpu.so
andlibtorch_xpu_ops_sycl_kernel.so
, and the commit also helps us make the bin size on par as CUDA. In the next stage, we willlibtorch_xpu.so
.