Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add SYCL registered kernel metadata into property sets #16821

Open
wants to merge 6 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Add SYCL registered kernel metadata into property sets #16821

wants to merge 6 commits into from
+138 −0

Conversation

jzc
Copy link
Contributor

@jzc jzc commented Jan 28, 2025

For the sycl kernel compiler extension, see #11985, #16485

@jzc jzc requested a review from a team as a code owner January 28, 2025 21:41
@jzc jzc temporarily deployed to WindowsCILock January 28, 2025 21:57 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to WindowsCILock January 28, 2025 22:44 — with GitHub Actions Inactive
@jopperm
Copy link
Contributor

jopperm commented Jan 30, 2025

LGTM from the SYCL-RTC side, thanks!

@maarquitos14
Copy link
Contributor

We also need at least an E2E test. It might be added in a follow up PR, but we need it.

@jopperm
Copy link
Contributor

jopperm commented Jan 30, 2025

I observed that after device code split, the resulting modules always contain all registered_kernel_names. Could we emit only the entries whose RHS exist in the current module? (Maybe this needs to be handled in the module splitter. There seems to be precedent here.)

@jzc
Copy link
Contributor Author

jzc commented Feb 4, 2025

@jopperm good point, I've updated the PR with the functionality to do this, take another look

@jzc jzc temporarily deployed to WindowsCILock February 4, 2025 15:18 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to WindowsCILock February 4, 2025 16:26 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to WindowsCILock February 10, 2025 15:30 — with GitHub Actions Inactive
maarquitos14
maarquitos14 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a reminder that we need a follow up PR with E2E testing.

@jzc jzc temporarily deployed to WindowsCILock February 10, 2025 16:52 — with GitHub Actions Inactive
jopperm
jopperm approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jopperm jopperm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the filtering!

llvm/test/tools/sycl-post-link/sycl-registered-kernels-empty.ll Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen left review comments

@jopperm jopperm jopperm approved these changes

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzc @jopperm @maarquitos14 @steffenlarsen