Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove sycl-devops-pr/** hack #16754

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

aelovikov-intel
Copy link
Contributor

It was originally added in #10002, back when we used pull_request_target for pre-commit trigger. Now that pull_request is used it isn't (as) necessary.

I'm also adding a workflow_dispatch trigger for the post-commit job for cases when somebody wants to test extensive non-CI changes with post-commit before the merge. I think that will work but it's impossible to verify before merging this due to how GHA work.

This will address the following usage scenario:

  • Push CI-related changes to sycl-devops-pr (possibly several iterations)
  • Result are ok, open a PR from that branch
    • extra post-commit task is spawned for the commit that has been tested already (this duplication will remain, unfortunately)
  • Address review feedback with a new upload
    • two post-commit jobs are automatically launched (after this PR, no manual dispatch would happen here, leaving only automatic pre-commit testing of the post-commit workflow)

It was originally added in #10002,
back when we used `pull_request_target` for pre-commit trigger. Now that
`pull_request` is used it isn't (as) necessary.

I'm also adding a `workflow_dispatch` trigger for the post-commit job
for cases when somebody wants to test extensive non-CI changes with
post-commit before the merge. I think that will work but it's impossible
to verify before merging this due to how GHA work.

This will address the following usage scenario:
  * Push CI-related changes to `sycl-devops-pr` (possibly several
    iterations)
  * Result are ok, open a PR from that branch
    - extra post-commit task is spawned for the commit that has been
      tested already (this duplication will remain, unfortunately)
  * Address review feedback with a new upload
    - two post-commit jobs are automatically launched (after this PR, no
      manual dispatch would happen here, leaving only automatic
      pre-commit testing of the post-commit workflow)
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aelovikov-intel
Copy link
Contributor Author

check-llvm-spirv are known and unrelated. Already addressed in #16743.

@aelovikov-intel aelovikov-intel merged commit 094e555 into sycl Jan 23, 2025
26 of 27 checks passed
@aelovikov-intel aelovikov-intel deleted the remove-devops-pr-hack branch January 23, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants