Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge OpenAI Triton commit 67dc627 #3112

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Merge OpenAI Triton commit 67dc627 #3112

merged 3 commits into from
Jan 8, 2025

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Jan 8, 2025 •
edited
Loading

Continuation of #3099

Inductor tests are not fully fixed after Triton signature changes. Will be done separately.

@ptillet
[FRONTEND] clean-up backend/jit interface (#5512)
67dc627 
This is a fairly big refactor of the JIT that prepares the field for
supporting named tuples (to come in a subsequent PR):
- fixes bug in tuple specialization hashes
- simplifies launcher by always taking all function arguments (even
unused constexprs)
- enables un-annotated constant expressions (necessary for variadic
tuples containing constexprs)
- replaces attrsdescriptor by much more minimal backend interfaces
- unifies constexprs provided by users (e.g., block sizes, none,
function arguments...) and specialization (e.g., 1)
anmyachev
anmyachev commented Jan 8, 2025
View reviewed changes
scripts/patch-pytorch.sh Outdated Show resolved Hide resolved
@anmyachev anmyachev changed the title Merge OpenAI Triton commit 67dc627 Merge OpenAI Triton commit 67dc627 Jan 8, 2025
@anmyachev anmyachev linked an issue Jan 8, 2025 that may be closed by this pull request
Merge 67dc627 #3087
Closed
@anmyachev
Copy link
Contributor Author

@kwasd @pbchekin /usr/bin/ld: final link failed: No space left on device issue is here again. Could you take a look?

@kwasd
Copy link
Contributor

kwasd commented Jan 8, 2025 •
edited
Loading

@kwasd @pbchekin /usr/bin/ld: final link failed: No space left on device issue is here again. Could you take a look?

Have reduced cache lifetime from 7 days to 6 days on this particular machine (in-place by editing the service file), which freed lots of space.
New job attempt is running: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12670637588?pr=3112

@anmyachev anmyachev force-pushed the amyachev/issue3087-2 branch from f8fa130 to 10e037c Compare January 8, 2025 14:37
@anmyachev anmyachev marked this pull request as ready for review January 8, 2025 14:38
@anmyachev anmyachev force-pushed the amyachev/issue3087-2 branch 2 times, most recently from 0021f48 to d94356f Compare January 8, 2025 16:49
@anmyachev
Copy link
Contributor Author

@kwasd error: [Errno 28] No space left on device :(

@anmyachev
Copy link
Contributor Author

@whitneywhtsang CI failed due to another reason unrelated to this PR. Ready for review.

whitneywhtsang
whitneywhtsang approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and do not squash and merge this PR.

@anmyachev
Copy link
Contributor Author

Please rebase and do not squash and merge this PR.

@whitneywhtsang BTW how do you rebase without breaking the merge commit?

@whitneywhtsang
Copy link
Contributor

Please rebase and do not squash and merge this PR.

@whitneywhtsang BTW how do you rebase without breaking the merge commit?

I redo the merge from the new base, and then force push.

@anmyachev anmyachev force-pushed the amyachev/issue3087-2 branch from d94356f to 8697d29 Compare January 8, 2025 17:51
@anmyachev
Copy link
Contributor Author

Please rebase and do not squash and merge this PR.

@whitneywhtsang BTW how do you rebase without breaking the merge commit?

I redo the merge from the new base, and then force push.

Looks like git rebase --rebase-merges main works for me.

@anmyachev anmyachev merged commit caf24cc into main Jan 8, 2025
5 of 6 checks passed
@anmyachev anmyachev deleted the amyachev/issue3087-2 branch January 8, 2025 20:03
@anmyachev anmyachev mentioned this pull request Jan 9, 2025
Closed
anmyachev added a commit that referenced this pull request Jan 9, 2025
@anmyachev
Fix PyTorch inductor tests after #3112
467715d 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev mentioned this pull request Jan 10, 2025
Closed
anmyachev added a commit that referenced this pull request Jan 10, 2025
@anmyachev
Fix PyTorch inductor tests after #3112 (#3126)
c74534d 
Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge 67dc627
4 participants
@anmyachev @kwasd @whitneywhtsang @ptillet