Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative prompt adherence for Non-Fast Standard modes #161

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mschuettlerTNG
Copy link
Contributor

Description:

This PR fixes the negative prompt adherence for all Non-Fast (i.e. non lcm) default modes. The negative prompt was not correctly forwarded to the model pipeline.
In addition, the negative prompt input for Fast modes is disabled, as with the current CFG of 1, the negative prompt has no influence during sampling.

Related Issue:

TNG#47

Changes Made:

  • forward negative_prompt to text_to_image pipeline
  • disable negative_prompt input for fast modes

Testing Done:

Tested locally on A750

Checklist:

  • I have tested the changes locally.
  • I have self-reviewed the code changes.

@Nuullll Nuullll merged commit 8d7bada into intel:dev Jan 30, 2025
7 checks passed
@mschuettlerTNG mschuettlerTNG deleted the fix-negative-prompt-for-sd branch February 4, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants