Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring for incremental cardano db #2265

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Monitoring for incremental cardano db #2265

wants to merge 5 commits into from
+586 −2

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Jan 30, 2025 •
edited
Loading

Content

Create following tracking route and send an event message with associated metric value:

  • /statistics/cardano-database/immutable-files-restored
    • increment metric cardano_database_immutable_files_restored_since_startup by the number of immutable files
  • /statistics/cardano-database/ancillary-files-restored
    • increment metric cardano_database_ancillary_files_restored_since_startup by 1
  • /statistics/cardano-database/complete-restoration
    • increment metric cardano_database_complete_restoration_since_startup by 1
    • send an EventMessage cardano_database_restoration with content complete
  • /statistics/cardano-database/partial-restoration
    • increment metric cardano_database_partial_restoration_since_startup by 1
    • send an EventMessage cardano_database_restoration with content partial

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2249

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Test Results

    4 files  ± 0     52 suites  ±0   10m 35s ⏱️ +3s
1 582 tests +13  1 582 ✅ +13  0 💤 ±0  0 ❌ ±0 
1 856 runs  +13  1 856 ✅ +13  0 💤 ±0  0 ❌ ±0 

Results for commit 078e4bf. ± Comparison against base commit 6c476bd.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2025
View reviewed changes
mithril-common/src/messages/cardano_database_ancillary_files_restored.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_ancillary_files_restored.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_complete_restoration.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_complete_restoration.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_immutable_files_restored.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_immutable_files_restored.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_partial_restoration.rs Fixed Show fixed Hide fixed
mithril-common/src/messages/cardano_database_partial_restoration.rs Fixed Show fixed Hide fixed
@sfauvel sfauvel force-pushed the sfa/2249/monitoring_for_incremental_cardano_db branch from 3d669de to 761dcdd Compare January 30, 2025 16:14
@sfauvel sfauvel force-pushed the sfa/2249/monitoring_for_incremental_cardano_db branch 2 times, most recently from bbc3d0d to cd0ec36 Compare January 30, 2025 17:52
@sfauvel sfauvel temporarily deployed to testing-preview January 30, 2025 19:08 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet January 30, 2025 19:08 — with GitHub Actions Inactive
@sfauvel sfauvel changed the title Sfa/2249/monitoring for incremental cardano db Monitoring for incremental cardano db Jan 31, 2025
@sfauvel sfauvel force-pushed the sfa/2249/monitoring_for_incremental_cardano_db branch from 60b793f to eb97acf Compare January 31, 2025 14:29
@sfauvel sfauvel temporarily deployed to testing-preview January 31, 2025 14:43 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet January 31, 2025 14:43 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/2249/monitoring_for_incremental_cardano_db branch from eb97acf to 709831c Compare January 31, 2025 14:51
@sfauvel sfauvel temporarily deployed to testing-preview January 31, 2025 14:59 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet January 31, 2025 14:59 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-preview January 31, 2025 16:12 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-preview January 31, 2025 16:21 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet January 31, 2025 16:21 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review January 31, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud Awaiting requested review from jpraynaud

@Alenar Alenar Awaiting requested review from Alenar

@dlachaume dlachaume Awaiting requested review from dlachaume

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfauvel