feat(extension): load historical tx on demand when scrolling [LW-12099] #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 5d450ee8
|
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
0297f2d to
12f26c5
Compare
przemyslaw-wlodek
changed the title
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
2 times, most recently
from
2f748f4 to
fabd258
Compare
mkazlauskas
requested changes
Jan 21, 2025
apps/browser-extension-wallet/src/lib/scripts/background/config.ts
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/lib/scripts/background/storage/extension-document-store.ts
Outdated
Show resolved
Hide resolved
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
fabd258 to
e7d8657
Compare
mkazlauskas
requested changes
Jan 21, 2025
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
0b36022 to
27e3221
Compare
mkazlauskas
reviewed
Jan 22, 2025
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
e98bab4 to
a42307e
Compare
przemyslaw-wlodek
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
fbb8e6b to
9c57765
Compare
vetalcore
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
3 times, most recently
from
8403fda to
5a8ca3b
Compare
vetalcore
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
4 times, most recently
from
77cdce4 to
a02a84b
Compare
vetalcore
approved these changes
Feb 5, 2025
vetalcore
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
a02a84b to
06823be
Compare
Co-authored-by: Martynas Kazlauskas <[email protected]> Co-authored-by: vetalcore <[email protected]> Co-authored-by: Lukasz Jagiela <[email protected]>
vetalcore
force-pushed
the
feat/limit-number-of-historical-tx-loaded
branch
from
06823be to
af45ff7
Compare
3 tasks
if user has multiple addresses, and one of the addresses has a large gap between transctions, it would skip some transactions this fix is very inefficient, because it drops and re-fetches txes it might be acceptable when combined with persistent cache
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Testing