-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firefox Support for Lace Wallet Extension #1308
Draft
danielmain
wants to merge
9
commits into
main
Choose a base branch
from
chore/firefox-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what are the CSP errors you are facing? |
- extracted common build steps for firefox and chrome extension. - Added dev build target for firefox
Allure Report
processReports: ❌ test report for 09ce2fc9
|
|
…nd script context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intention
This pull request aims to extend the Lace Wallet browser extension support to Firefox. The Lace Wallet, initially built and optimized for Chrome, now includes compatibility for Firefox. However, there are certain runtime issues that need addressing, particularly related to Content Security Policy (CSP) violations.
Current Status
The Firefox extension can be successfully loaded and installed as shown in the screenshot.
![image](https://private-user-images.githubusercontent.com/4303099/350357220-241a5ac6-9c8a-4141-83b2-b8489ca4bb44.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODYwMjQsIm5iZiI6MTczOTI4NTcyNCwicGF0aCI6Ii80MzAzMDk5LzM1MDM1NzIyMC0yNDFhNWFjNi05YzhhLTQxNDEtODNiMi1iODQ4OWNhNGJiNDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTQ1NTI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjZjMTRmMGVlNmI3ZjQ2MjZiMjVhOTc2Y2U5ZWQ3Nzk5YTA0MGJmODRmMjU5NzAwY2E5ODZlMGJlNzQ5MGZlZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.LlE4cPmXAe-3qu8mH0KOSaDpXHLCO762nXoMe2Sx3Ts)
However, upon running, it encounters CSP-related runtime errors. Specifically, the following error is observed:
Steps to Build
Navigate to the
apps/browser-extension-wallet
directory in your project.Run the following command to build the Firefox extension:
Upon successful build, an artifact is created in the directory:
Additional Notes
.env
file to configure the manifest file appropriately for Firefox.about:debugging#/runtime/this-firefox
) shows the extension loaded in Firefox Developer Edition (129.0), with runtime errors available upon inspection.