Add new attributes for separate IPv4 and IPv6 addresses #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxPowered42
force-pushed
the
k_intern_ip_stage_1_single_table
branch
5 times, most recently
from
eb02a9e to
def6cb1
Compare
TuxPowered42
force-pushed
the
k_intern_ip_stage_1_single_table
branch
from
def6cb1 to
1452f4b
Compare
Since we have to introduce this for all attributes including none inet attributes I think it makes more sense to make the default blank instead of any.
kofrezo
force-pushed
the
k_intern_ip_stage_1_single_table
branch
from
4873f54 to
fe6c4f3
Compare
|
Add some commits as code review (suggestions) to discuss. We can drop them if not needed and I adjusted the tests for the new behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.