Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /changes breaks due to multiple rows returned #341

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

kofrezo
Copy link
Contributor

@kofrezo kofrezo commented Feb 1, 2024

In the previous days of Serveradmin we allowed to restore objects with the same id. This can lead to an object being in the history as deleted multiple times.

@kofrezo kofrezo added the bug label Feb 1, 2024
@kofrezo kofrezo self-assigned this Feb 1, 2024
@kofrezo kofrezo force-pushed the dk_fix_changes_subquery branch from b5ccdf6 to d643eda Compare February 1, 2024 09:36
In the previous days of Serveradmin we allowed to restore objects with
the same id. This can lead to an object being in the history as deleted
multiple times.
@kofrezo kofrezo force-pushed the dk_fix_changes_subquery branch from d643eda to ccdb22f Compare February 1, 2024 09:49
@kofrezo kofrezo marked this pull request as ready for review February 1, 2024 09:54
@kofrezo kofrezo requested a review from brainexe February 1, 2024 09:55
@kofrezo kofrezo merged commit 7f5a3f8 into main Feb 1, 2024
5 checks passed
@kofrezo kofrezo deleted the dk_fix_changes_subquery branch February 1, 2024 14:30
YannikSc pushed a commit to YannikSc/serveradmin that referenced this pull request Apr 19, 2024
In the previous days of Serveradmin we allowed to restore objects with
the same id. This can lead to an object being in the history as deleted
multiple times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants