Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: bump deps #134

Merged
merged 3 commits into from
Feb 4, 2025
Merged

chores: bump deps #134

merged 3 commits into from
Feb 4, 2025

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Feb 4, 2025

Description

bump deps to latest


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Chores

    • Updated the testing environment and various dependency libraries to newer versions for improved compatibility and performance.
  • Refactor

    • Removed a legacy feature for currency pair retrieval.
    • Modified a pricing update method to use a standardized context parameter.

@beer-1 beer-1 requested a review from Vritra4 February 4, 2025 07:18
@beer-1 beer-1 self-assigned this Feb 4, 2025
@beer-1 beer-1 requested a review from a team as a code owner February 4, 2025 07:18
Copy link

coderabbitai bot commented Feb 4, 2025

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""

Walkthrough

This pull request updates the environment and dependency management for the project. The GitHub Actions workflow now sets up Go version 1.23, and both module files (go.mod and api/go.mod) have been revised to update various dependency versions and remove obsolete ones. Additionally, the OracleKeeper interface has been modified: the method to retrieve all currency pairs has been removed while another method’s context parameter has been changed from sdk.Context to context.Context.

Changes

File(s) Change Summary
.github/workflows/test.yml Updated Go version in CI from 1.22 to 1.23.
api/go.mod, go.mod Upgraded Go and toolchain versions; updated multiple dependency versions (e.g., grpc, cosmos/ibc-go, skip-mev packages, testify, etc.); removed some obsolete dependencies.
x/opchild/types/expected_keepers.go Removed GetAllCurrencyPairs method and modified SetPriceForCurrencyPair signature by replacing sdk.Context with context.Context.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant Runner as GitHub Runner
    participant Setup as Go Setup Action
    participant Tests as Test Suite

    U->>Runner: Push commit with updated workflow
    Runner->>Setup: Read and set up Go version (1.23)
    Setup-->>Runner: Environment ready with Go 1.23
    Runner->>Tests: Execute test suite
    Tests-->>Runner: Return test results
Loading
sequenceDiagram
    participant Client as Caller
    participant Oracle as OracleKeeper Impl

    Client->>Oracle: Call SetPriceForCurrencyPair(context.Context, cp, qp)
    Oracle-->>Client: Return result/error
Loading

Possibly related PRs

Suggested reviewers

  • Vritra4

Poem

Hoppity-hop, I nibble the code,
Versions updated down every road.
Dependencies leap with a joyful bound,
Interfaces skip with a merry sound.
This little rabbit cheers the change so bright—
Carrots and code, our future’s in sight! 🥕✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5302ad2 and 6d1424a.

⛔ Files ignored due to path filters (3)
  • api/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • go.work is excluded by !**/*.work
📒 Files selected for processing (4)
  • .github/workflows/test.yml (1 hunks)
  • api/go.mod (1 hunks)
  • go.mod (7 hunks)
  • x/opchild/types/expected_keepers.go (1 hunks)
🔇 Additional comments (5)
x/opchild/types/expected_keepers.go (1)

56-59: Verify impact of breaking changes in OracleKeeper interface.

The interface has undergone breaking changes:

  1. Removal of GetAllCurrencyPairs method
  2. Change of context type in SetPriceForCurrencyPair from sdk.Context to context.Context
✅ Verification successful

Breaking changes verified – no lingering references to deprecated methods.

  • No implementations using the old signature (SetPriceForCurrencyPair with sdk.Context) were found.
  • No references to the removed GetAllCurrencyPairs method exist.

These findings indicate that the breaking changes in the OracleKeeper interface have been applied consistently.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for implementations of OracleKeeper interface
ast-grep --pattern 'type $_ struct {
  $$$
}

func ($_ $_) SetPriceForCurrencyPair(ctx sdk.Context, $$$) error {
  $$$
}'

Length of output: 123


Script:

#!/bin/bash
# Verify implementations now use context.Context in SetPriceForCurrencyPair
echo "Searching for implementations of SetPriceForCurrencyPair using context.Context parameter:"
rg -n "SetPriceForCurrencyPair(ctx context.Context" .

# Search for any remaining definitions or usages of GetAllCurrencyPairs,
# which was removed in the updated interface.
echo "Searching for any references to GetAllCurrencyPairs:"
rg -n "func.*GetAllCurrencyPairs" .

Length of output: 515

api/go.mod (1)

10-11: Verify compatibility of gRPC and protobuf updates.

The updates to gRPC (v1.68.1) and protobuf (v1.35.2) appear to be minor version bumps. Let's verify these versions.

✅ Verification successful

Compatibility Check: gRPC & Protobuf Version Updates

The dependency updates in api/go.mod are minor patch bumps that maintain backward compatibility:

  • gRPC: Upgraded from v1.67.1 to v1.68.1. Although the latest stable release as of February 2025 is v1.70.1, the v1.68.1 update is safe and consistent with semantic versioning expectations.
  • Protobuf: Updated from v1.35.1 to v1.35.2. This minor revision aligns with current toolchain recommendations while ensuring generated code remains compatible.

No issues were found with these updates, and they appear appropriate for the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Web query:

What are the latest stable versions of google.golang.org/grpc and google.golang.org/protobuf?

Length of output: 5955

.github/workflows/test.yml (1)

30-30: Verify Go version 1.23 stability.

The workflow has been updated to use Go 1.23. Let's verify this version's stability.

✅ Verification successful

Go 1.23 is stable and production-ready.

  • Release Confirmation: Go 1.23 was officially released on August 13, 2024.
  • Latest Stable Patch: The most up-to-date patch, Go 1.23.5 (released January 16, 2025), is available.
  • Support & Stability: The Go release policy and compatibility promise ensure stability for production use until two newer major versions are available.

The update in the workflow to specify go-version: 1.23 is therefore consistent with using a stable, supported version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Web query:

Is Go 1.23 released and stable? What is the latest stable version of Go?

Length of output: 2375

go.mod (2)

3-5: Verify Go version and toolchain compatibility.

The Go version has been updated to 1.23.1 and toolchain to go1.23.2. Let's verify these versions.

✅ Verification successful

Verification Successful: Go Version and Toolchain Compatibility Confirmed

  • The go.mod file correctly specifies Go version 1.23.1 and toolchain go1.23.2, which are both stable minor revisions.
  • Differences between these versions are limited to patch-level fixes:
    • Go 1.23.1: Contains security fixes (e.g., for encoding/gob, go/build/constraint, go/parser) and several bug fixes in core packages.
    • Go 1.23.2: Addresses additional bug fixes in areas like compiler, cgo/runtime issues, maps, os/exec, and memory management.
  • Both releases follow the Go team’s maintenance and release policies and are suitable for production use.
🏁 Scripts executed

The following scripts were executed for the analysis:

Web query:

What is the difference between Go 1.23.1 and go1.23.2 toolchain? Are these versions stable?

Length of output: 2770


23-23: Verify compatibility of core dependency updates.

Significant updates to core dependencies:

  • cosmos/ibc-go/v8: v8.5.0 → v8.5.3
  • skip-mev/block-sdk/v2: v2.1.1 → v2.1.5
  • skip-mev/connect/v2: v2.0.1 → v2.3.0

Also applies to: 29-30

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.38%. Comparing base (5302ad2) to head (6d1424a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   49.38%   49.38%           
=======================================
  Files          57       57           
  Lines        4275     4275           
=======================================
  Hits         2111     2111           
  Misses       1726     1726           
  Partials      438      438           

@beer-1 beer-1 merged commit d7582ff into main Feb 4, 2025
8 of 9 checks passed
@beer-1 beer-1 deleted the chores/bump-deps branch February 4, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant