Skip to content

Commit

Permalink
Remove test assertion of the TimeoutException message wording
Browse files Browse the repository at this point in the history
The message itself comes from the php-websocket library, and
the wording depends on the installed version (it has changed
in phrity/websocket:1.7.0).

In the past, chrome-mink-driver had runtime code which depended
on the exact wording of this exception but that was removed in
4365fc4 - the message text is no longer relevant to this
package so there is no need to couple the tests to the internals
of php-websocket.
  • Loading branch information
acoulton committed Feb 2, 2024
1 parent 5419e31 commit 2465c89
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tests/ChromeDriverConnectionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public function testTimeoutExceptionIfResponseBlocked()
];
$this->driver = new ChromeDriver('http://localhost:9222', null, 'about:blank', $options);
$this->expectException(TimeoutException::class);
$this->expectExceptionMessage('Client read timeout');
$script = "confirm('Is the browser blocked? (yes, it is)');";
$this->driver->visit('about:blank');
$this->driver->evaluateScript($script);
Expand Down

0 comments on commit 2465c89

Please sign in to comment.