This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Add http.time_ms to all logs #49
Open
rubensf
wants to merge
1
commit into
improbable-eng:master
Choose a base branch
from
rubensf:feature/http.time_ms-log
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,12 +21,14 @@ var ( | |
// | ||
// All handlers will have a Logrus logger in their context, which can be fetched using `ctxlogrus.Extract`. | ||
func Middleware(entry *logrus.Entry, opts ...Option) httpwares.Middleware { | ||
entry.Logger.Hooks.Add(&timeHook{}) | ||
return func(nextHandler http.Handler) http.Handler { | ||
options := evaluateMiddlewareOpts(opts) | ||
return http.HandlerFunc(func(resp http.ResponseWriter, req *http.Request) { | ||
wrappedResp := httpwares.WrapResponseWriter(resp) | ||
|
||
requestFields := appendFields(newServerRequestFields(req), options.requestFieldExtractor(req)) | ||
startTime := time.Now() | ||
requestFields := appendFields(newServerRequestFields(req, startTime), options.requestFieldExtractor(req)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. whilst were in could we change this to use |
||
newEntry := entry.WithFields(requestFields) | ||
newReq := req.WithContext(ctxlogrus.ToContext(req.Context(), newEntry)) | ||
var capture *responseCapture | ||
|
@@ -36,7 +38,6 @@ func Middleware(entry *logrus.Entry, opts ...Option) httpwares.Middleware { | |
} | ||
}) | ||
|
||
startTime := time.Now() | ||
nextHandler.ServeHTTP(wrappedResp, newReq) | ||
capture.finish() // captureResponse has a nil check, this can be nil | ||
|
||
|
@@ -70,7 +71,7 @@ func responseFields(wrappedResp httpwares.WrappedResponseWriter, startTime time. | |
return postCallFields | ||
} | ||
|
||
func newServerRequestFields(req *http.Request) logrus.Fields { | ||
func newServerRequestFields(req *http.Request, startTime time.Time) logrus.Fields { | ||
host := req.URL.Host | ||
if host == "" { | ||
host = req.Host | ||
|
@@ -86,6 +87,7 @@ func newServerRequestFields(req *http.Request) logrus.Fields { | |
"http.request.user_agent": req.Header.Get("User-Agent"), | ||
"http.request.length_bytes": req.ContentLength, | ||
"http.request.referer": req.Referer(), | ||
"http.start_time": startTime, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we use |
||
} | ||
|
||
if addr := req.RemoteAddr; addr != "" { | ||
|
@@ -129,3 +131,17 @@ func timeDiffToMilliseconds(then time.Time) float32 { | |
} | ||
return float32(sub/1000) / 1000.0 | ||
} | ||
|
||
type timeHook struct{} | ||
|
||
func (*timeHook) Levels() []logrus.Level { | ||
return logrus.AllLevels | ||
} | ||
|
||
func (*timeHook) Fire(entry *logrus.Entry) error { | ||
if startTime, ok := entry.Data["http.start_time"]; ok { | ||
entry.Data["http.time_ms"] = timeDiffToMilliseconds(startTime.(time.Time)) | ||
} | ||
|
||
return nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer to just do this inline ... rather than adding
hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the PR context and offline discussion, I can't think of a good way of doing this without hooks.