Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): versions the Docker cleaning action to latest released #2438

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

stumpylog
Copy link
Contributor

This is a follow up to #2302.

I've versioned my action, and set that latest release as the version for immich to use. This also lets me continue to develop the action without affecting users. This version has been running over here without issue.

This also enables the actual deletion. I've been watching the dry runs and the images which would be removed all look correct, so I feel confident in enabling the actual deletion at this point.

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) May 15, 2023 5:16pm

@alextran1502 alextran1502 merged commit f4aefcb into immich-app:main May 15, 2023
@stumpylog
Copy link
Contributor Author

The warnings from the last run will continue for a bit. There's enough untagged (ie not reachable) packages the rate limit will be hit for a few more runs. At most 5000 requests per hour when there's so many versions will take a few runs to fully complete.

Runs after these first few will be much quicker and won't encounter the rate limits.

lukehmcc added a commit to lukehmcc/immich that referenced this pull request May 17, 2023
refactor(web): use ImmichApi to create urls (immich-app#2435)

feat (server, web): Share with partner (immich-app#2388)

* feat(server, web): implement share with partner

* chore: regenerate api

* chore: regenerate api

* Pass userId to getAssetCountByTimeBucket and getAssetByTimeBucket

* chore: regenerate api

* Use AssetGrid to view partner's assets

* Remove disableNavBarActions flag

* Check access to buckets

* Apply suggestions from code review

Co-authored-by: Jason Rasmussen <[email protected]>

* Remove exception rethrowing

* Simplify partner access check

* Create new PartnerController

* chore api:generate

* Use partnerApi

* Remove id from PartnerResponseDto

* Refactor PartnerEntity

* Rename args

* Remove duplicate code in getAll

* Create composite primary keys for partners table

* Move asset access check into PartnerCore

* Remove redundant getUserAssets call

* Remove unused getUserAssets method

* chore: regenerate api

* Simplify getAll

* Replace ?? with ||

* Simplify PartnerRepository.create

* Introduce PartnerIds interface

* Replace two database migrations with one

* Simplify getAll

* Change PartnerResponseDto to include UserResponseDto

* Move partner sharing endpoints to PartnerController

* Rename ShareController to SharedLinkController

* chore: regenerate api after rebase

* refactor: shared link remove return type

* refactor: return user response dto

* chore: regenerate open api

* refactor: partner getAll

* refactor: partner settings event typing

* chore: remove unused code

* refactor: add partners modal trigger

* refactor: update url for viewing partner photos

* feat: update partner sharing title

* refactor: rename service method names

* refactor: http exception logic to service, PartnerIds interface

* chore: regenerate open api

* test: coverage for domain code

* fix: addPartner => createPartner

* fix: missed rename

* refactor: more code cleanup

* chore: alphabetize settings order

* feat: stop sharing confirmation modal

* Enhance contrast of the email in dark mode

* Replace button with CircleIconButton

* Fix linter warning

* Fix date types for PartnerEntity

* Fix PartnerEntity creation

* Reset assetStore state

* Change layout of the partner's assets page

* Add bulk download action for partner's assets

---------

Co-authored-by: Jason Rasmussen <[email protected]>

chore(ci): versions the Docker cleaning action to latest released (immich-app#2438)

chore(web): update eslint and prettier packages (immich-app#2437)

Co-authored-by: Alex <[email protected]>

docs: remove roadmap link (immich-app#2442)

refactor(web): asset select actions (immich-app#2444)

* refactor(web): asset select actions

* remaining pages/components + data flow changes

* fix check

fix(web): use correct favicon sizes (immich-app#2446)

* fix(web): use correct favicon sizes

Signed-off-by: martin <[email protected]>

* fix: format

Signed-off-by: martin <[email protected]>

---------

Signed-off-by: martin <[email protected]>

fix(web): layout spacing when zooming (immich-app#2452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants