Annotations
3 errors and 12 warnings
the trait bound `cartridge::cartridge::Cartridge: std::convert::From<std::vec::Vec<u8>>` is not satisfied:
src/lib/egui/gui.rs#L246
error[E0277]: the trait bound `cartridge::cartridge::Cartridge: std::convert::From<std::vec::Vec<u8>>` is not satisfied
--> src/lib/egui/gui.rs:246:37
|
246 | let cartridge = Cartridge::try_from(file_contents)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::vec::Vec<u8>>` is not implemented for `cartridge::cartridge::Cartridge`, which is required by `cartridge::cartridge::Cartridge: std::convert::TryFrom<std::vec::Vec<u8>>`
|
= help: the following other types implement trait `std::convert::TryFrom<T>`:
`cartridge::cartridge::Cartridge` implements `std::convert::TryFrom<&[u8]>`
`cartridge::cartridge::Cartridge` implements `std::convert::TryFrom<&std::vec::Vec<u8>>`
= note: required for `std::vec::Vec<u8>` to implement `std::convert::Into<cartridge::cartridge::Cartridge>`
= note: required for `cartridge::cartridge::Cartridge` to implement `std::convert::TryFrom<std::vec::Vec<u8>>`
|
the trait bound `cartridge::cartridge::Cartridge: std::convert::TryFrom<std::vec::Vec<u8>>` is not satisfied:
src/lib/egui/gui.rs#L246
error[E0277]: the trait bound `cartridge::cartridge::Cartridge: std::convert::TryFrom<std::vec::Vec<u8>>` is not satisfied
--> src/lib/egui/gui.rs:246:37
|
246 | let cartridge = Cartridge::try_from(file_contents)
| ^^^^^^^^^ the trait `std::convert::From<std::vec::Vec<u8>>` is not implemented for `cartridge::cartridge::Cartridge`, which is required by `cartridge::cartridge::Cartridge: std::convert::TryFrom<std::vec::Vec<u8>>`
|
= help: the following other types implement trait `std::convert::TryFrom<T>`:
`cartridge::cartridge::Cartridge` implements `std::convert::TryFrom<&[u8]>`
`cartridge::cartridge::Cartridge` implements `std::convert::TryFrom<&std::vec::Vec<u8>>`
= note: required for `std::vec::Vec<u8>` to implement `std::convert::Into<cartridge::cartridge::Cartridge>`
= note: required for `cartridge::cartridge::Cartridge` to implement `std::convert::TryFrom<std::vec::Vec<u8>>`
|
clippy_check
Clippy had exited with the 101 exit code
|
unused variable: `opcode`:
src/lib/cpu/cpu.rs#L284
warning: unused variable: `opcode`
--> src/lib/cpu/cpu.rs:284:13
|
284 | let opcode: OpCode = self.read(self.program_counter).into();
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode`
|
= note: `#[warn(unused_variables)]` on by default
|
using tabs in doc comments is not recommended:
src/lib/ppu.rs#L18
warning: using tabs in doc comments is not recommended
--> src/lib/ppu.rs:18:13
|
18 | /// | 0x3F00 | Universal background color |
| ^^^^ help: consider using four spaces per tab
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
= note: `#[warn(clippy::tabs_in_doc_comments)]` on by default
|
unused import: `pixels::Pixels`:
src/lib/ppu.rs#L1
warning: unused import: `pixels::Pixels`
--> src/lib/ppu.rs:1:5
|
1 | use pixels::Pixels;
| ^^^^^^^^^^^^^^
|
unnecessary `pub(self)`:
src/lib/opcodes/mod.rs#L5
warning: unnecessary `pub(self)`
--> src/lib/opcodes/mod.rs:5:1
|
5 | pub(self) mod operations;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
|
unnecessary `pub(self)`:
src/lib/cpu/addressing.rs#L80
warning: unnecessary `pub(self)`
--> src/lib/cpu/addressing.rs:80:1
|
80 | pub(self) mod fetching {
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default
|
unused import: `fmt::format`:
src/lib/cpu/cpu.rs#L10
warning: unused import: `fmt::format`
--> src/lib/cpu/cpu.rs:10:26
|
10 | use std::{cell::RefCell, fmt::format, rc::Rc};
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|