Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #120

Closed
wants to merge 2 commits into from
Closed

Main #120

wants to merge 2 commits into from

Conversation

deepikasidana89
Copy link

@deepikasidana89 deepikasidana89 commented May 5, 2022

Adding method to Play sound from file.
Fixing Issue - #108

@deepikasidana89
Copy link
Author

@iluwatar can you please review

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the pull request. Please address these two issues

  • The test is failing (the sound file can't be found)
  • Checkstyle is failing the build due to source code formatting

Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@stale
Copy link

stale bot commented Dec 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale label Dec 31, 2022
@stale
Copy link

stale bot commented Feb 14, 2023

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants