fix: Return only live pages from search promotions

[kesara]

Fixes #532

[rjsparks]

I think we should consider this a patch fix.

The real issue is in some Page (or derived from Page) objects search that we've written not restricting things to .live() when they should and that may surface in other parts of the application, so we should hunt for how search_query as passed to get_search_promotions is being built and fix it at that point.

[kesara]

I think we should consider this a patch fix.

The real issue is in some Page (or derived from Page) objects search that we've written not restricting things to .live() when they should and that may surface in other parts of the application, so we should hunt for how search_query as passed to get_search_promotions is being built and fix it at that point.

I don't see any custom changes for search promotions.
For every search query www adds daily hit record:
https://github.com/search?q=repo:ietf-tools/www%20promotions&type=code#L15

Also, www hasn't been running periodic events for cleaning up daily search records¹.
This could be the root cause but running this command manually didn't help the search results. But there are few other periodic tasks www.ietf.org should be running, so that has be to addressed.

Footnotes

1. https://docs.wagtail.org/en/v6.3.2/reference/contrib/searchpromotions.html#searchpromotions-garbage-collect ↩