chore: github actions workflow for tests / visual regressions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jennifer-richards now that we've got unit tests I've added a workflow to run those, TS, and linting on CI. Because the Nuxt build and TS require the generated API client we'll need to have the client on CI. It would be best to generate that on CI so that we have current types, but as we can't do that yet I've temporarily commited the API client (which is a single file) to test this workflow. |
jennifer-richards
previously approved these changes
Dec 13, 2024
NGPixel
requested changes
Dec 13, 2024
.github/workflows/tests.yml
Outdated
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 23.x |
There was a problem hiding this comment.
I would avoid using non-LTS versions in anything unless absolutely necessary.
There was a problem hiding this comment.
Ah it was the quickest fix for this... I'll look for a workaround
https://github.com/ietf-tools/rfced-www/actions/runs/12311686063/job/34362303820
NGPixel
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generateddirectoryvis-reg-test.ymlto the more readablevisual-regression-test.yml