-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keep proceedings cache up to date via celery #8449
Merged
rjsparks
merged 15 commits into
ietf-tools:main
from
jennifer-richards:proceedings-cache
Feb 5, 2025
Merged
feat: keep proceedings cache up to date via celery #8449
rjsparks
merged 15 commits into
ietf-tools:main
from
jennifer-richards:proceedings-cache
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_schedule() with name=None should perhaps be an anti-pattern
This looks on target to me |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8449 +/- ##
==========================================
+ Coverage 88.81% 88.88% +0.07%
==========================================
Files 312 312
Lines 40856 40891 +35
==========================================
+ Hits 36285 36347 +62
+ Misses 4571 4544 -27 ☔ View full report in Codecov by Sentry. |
rjsparks
previously approved these changes
Feb 3, 2025
rjsparks
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs at least updates to the tests, but wanted to get it out for feedback before going further.
The idea here is to cache all the IETF meeting proceedings for a day and refresh the cache via celery. To avoid long-running celery jobs, the refresh task is designed to run hourly but only to update a couple proceedings at a time. We'll hopefully have a better method for managing the proceedings content in place before we reach more than 2-3 proceedings falling into any bin.
There were a few date parameters being supplied to the proceedings template but it looks to me like those must be relics. I traced the templates and don't see where any of the things I removed were being used indirectly. In view of that, it may be possible to adjust the boundary of the cached HTML fragment.
To avoid serving misinformation around the time when a meeting's proceedings are finalized, I've added that value to the cache key. This may result in one or a few long-running HTTP requests if we get a few people requesting the proceedings after the switch. We could consider refreshing the current proceedings immediately upon finalizing to avoid / reduce the cross section to that.