Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep proceedings cache up to date via celery #8449

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

jennifer-richards
Copy link
Member

This still needs at least updates to the tests, but wanted to get it out for feedback before going further.

The idea here is to cache all the IETF meeting proceedings for a day and refresh the cache via celery. To avoid long-running celery jobs, the refresh task is designed to run hourly but only to update a couple proceedings at a time. We'll hopefully have a better method for managing the proceedings content in place before we reach more than 2-3 proceedings falling into any bin.

There were a few date parameters being supplied to the proceedings template but it looks to me like those must be relics. I traced the templates and don't see where any of the things I removed were being used indirectly. In view of that, it may be possible to adjust the boundary of the cached HTML fragment.

To avoid serving misinformation around the time when a meeting's proceedings are finalized, I've added that value to the cache key. This may result in one or a few long-running HTTP requests if we get a few people requesting the proceedings after the switch. We could consider refreshing the current proceedings immediately upon finalizing to avoid / reduce the cross section to that.

@rjsparks
Copy link
Member

This looks on target to me

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (3b8faf0) to head (5387c9b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
ietf/meeting/tasks.py 87.50% 2 Missing ⚠️
ietf/meeting/utils.py 97.56% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8449      +/-   ##
==========================================
+ Coverage   88.81%   88.88%   +0.07%     
==========================================
  Files         312      312              
  Lines       40856    40891      +35     
==========================================
+ Hits        36285    36347      +62     
+ Misses       4571     4544      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rjsparks
rjsparks previously approved these changes Feb 3, 2025
@rjsparks rjsparks merged commit 060320d into ietf-tools:main Feb 5, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the proceedings-cache branch February 5, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants