Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zero address checking #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add zero address checking #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/cross-chain/CrossChainProofValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ contract CrossChainProofValidator is Ownable, EIP712, ICrossChainProofValidator
string memory signatureVersion,
address oracleSigningAddress
) EIP712(domainName, signatureVersion) Ownable(msg.sender) {
require(oracleSigningAddress != address(0), "Oracle signing address should not be zero");
bytes32 hashedName = keccak256(bytes(domainName));
bytes32 hashedVersion = keccak256(bytes(signatureVersion));
uint256 chainId = 0;
Expand All @@ -63,6 +64,7 @@ contract CrossChainProofValidator is Ownable, EIP712, ICrossChainProofValidator
* @param oracleSigningAddress The new oracle signing address
**/
function setOracleSigningAddress(address oracleSigningAddress) public onlyOwner {
require(oracleSigningAddress != address(0), "Oracle signing address should not be zero");
_oracleSigningAddress = oracleSigningAddress;
}

Expand Down