Fix #3322: Add missing checks for equality comparison #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrunwald
reviewed
Jan 14, 2025
| && (conversions.IdentityConversion(lhsType, rhsType) | ||
| || conversions.ExplicitConversion(lhsType, rhsType).IsReferenceConversion | ||
| || conversions.IdentityConversion(rhsType, lhsType) | ||
| || conversions.ExplicitConversion(rhsType, lhsType).IsReferenceConversion)) |
There was a problem hiding this comment.
Is this condition coming from some spec?
I think this might be overly restrictive; wasn't if (obj == 42) also allowed (with a warning)?
Though I guess being overly restrictive here will just result in some harmless redundant casts.
There was a problem hiding this comment.
Btw identity conversions are always symmetric, so if you already checked IdentityConversion(lhsType, rhsType) you don't need to also check IdentityConversion(rhsType, lhsType), as that will always have the same result.
There was a problem hiding this comment.
Is this condition coming from some spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.