Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Central package management (requires package source mapping) #3124

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

christophwille
Copy link
Member

@christophwille christophwille commented Nov 20, 2023

Apply Central package management https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management (requires package source mapping https://learn.microsoft.com/en-us/nuget/consume-packages/package-source-mapping)

DSR Converter Xml package dependencies:
image

picked nearest

  • Microsoft.DiaSymReader 1.4.0
  • Microsoft.DiaSymReader.Native 17.0.0-beta1.21524.1

"Worst" alternative would be to ignore package source mapping

<PropertyGroup>
  <NoWarn>$(NoWarn);NU1507</NoWarn>
</PropertyGroup>

Installer and VS solutions intentionally do not participate in central package management.

@christophwille christophwille merged commit 084d02a into master Nov 23, 2023
9 checks passed
@christophwille christophwille deleted the feature/cpm branch November 23, 2023 06:25
mattsh247 pushed a commit to mattsh247/ILSpy that referenced this pull request Jul 30, 2024
…csharpcode#3124)

* Apply Central package management https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management (requires package source mapping https://learn.microsoft.com/en-us/nuget/consume-packages/package-source-mapping)

* Microsoft.DiaSymReader.Converter.Xml from dotnet-tools, Microsoft.DiaSymReader.Native from nuget.org feed

* Trying to sort what is on which feed for previews of Diasymreader packages

* Parse the Roslyn version from Directory.packages.props

* Use specific versions for Diasymreader from nuget.org to allow VS2022 addin to restore properly

* Tests needs also locked references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant