Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and use tuple element names and dynamic type information from PDBs #3114

Merged

Conversation

ElektroKill
Copy link
Contributor

@ElektroKill ElektroKill commented Nov 7, 2023

Link to issue(s) this covers:
fixes #3112

Problem

ILSpy did not utilize helpful type information from PDB files when determining the type of local variables.

Solution

  • Implementation as mentioned in the original issue.
  • Added additional code to extract the necessary information from the PDB file and added a new TypeVisitor to apply this information to the type system.

@siegfriedpammer
Copy link
Member

In general LGTM, however, we should discuss the method signature of TryGetExtraTypeInfo.

@siegfriedpammer siegfriedpammer self-assigned this Dec 12, 2023
@ElektroKill
Copy link
Contributor Author

The build seems to be failing after the recent upgrade of the upload artifact GH action. Looking at the error it looks like a limit for the amount of artifacts was imposed.

@riQQ
Copy link
Contributor

riQQ commented Dec 24, 2023

@siegfriedpammer siegfriedpammer merged commit 760e7e0 into icsharpcode:master Dec 24, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tuple element name and dynamic type information for local from PDB
3 participants