docs: fix missing self in down migration example of readme

fixes #41 Signed-off-by: Saurav Sharma <[email protected]>
iamsauravsharma · Jan 12, 2025 · 5a9e688 · 5a9e688
1 parent db33b26
commit 5a9e688
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/README.MD b/README.MD
@@ -63,7 +63,7 @@ impl Operation<sqlx::Postgres> for FirstOperation {
     }
 
     // down migration runs down migration
-    async fn down(connection: &mut sqlx::PgConnection) -> Result<(), Error> {
+    async fn down(&self, connection: &mut sqlx::PgConnection) -> Result<(), Error> {
         sqlx::query("DROP TABLE sample").execute(connection).await?;
         Ok(())
     }

diff --git a/src/migrator/mod.rs b/src/migrator/mod.rs
@@ -870,10 +870,11 @@ where
             match plan.plan_type {
                 PlanType::Apply => {
                     tracing::debug!("applying {} : {}", migration.app(), migration.name());
+                    let operations = migration.operations();
                     if migration.is_atomic() {
                         let mut transaction = connection.begin().await?;
                         if !plan.fake {
-                            for operation in migration.operations() {
+                            for operation in operations {
                                 operation.up(&mut transaction).await?;
                             }
                         }
@@ -882,7 +883,7 @@ where
                         transaction.commit().await?;
                     } else {
                         if !plan.fake {
-                            for operation in migration.operations() {
+                            for operation in operations {
                                 operation.up(connection).await?;
                             }
                         }