Added open event

iamphill · Mar 28, 2016 · bd6f68e · bd6f68e
1 parent d2598be
commit bd6f68e
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 3 deletions.
diff --git a/dist/js/bootstrap.offcanvas.js b/dist/js/bootstrap.offcanvas.js
diff --git a/dist/js/bootstrap.offcanvas.min.js b/dist/js/bootstrap.offcanvas.min.js
diff --git a/src/coffee/bootstrap.offcanvas.coffee b/src/coffee/bootstrap.offcanvas.coffee
@@ -207,6 +207,9 @@
 
                     @target.on 'offcanvas.close', (e) =>
                         @_close e
+
+                    @target.on 'offcanvas.open', (e) =>
+                        @_open e
             else
                 # Just log a warning
                 console.warn 'Offcanvas: `data-target` attribute must be present.'
@@ -237,8 +240,23 @@
 
             @bodyOverflow()
 
+        _open: (e) =>
+            e.preventDefault()
+            return if @target.is '.in'
+
+            @_sendEventsBefore()
+
+            # Toggle in class
+            @target.addClass 'in'
+            @element.addClass 'is-open'
+
+            @_navbarHeight()
+
+            @bodyOverflow()
+
         _close: (e) =>
             e.preventDefault()
+            return if @target.is ':not(.in)'
 
             @_sendEventsBefore()
 

diff --git a/tests/test.js b/tests/test.js
@@ -45,8 +45,12 @@
         assert.ok(!$("#js-bootstrap-offcanvas").hasClass("in"), "Off-Canvas should not be visible");
     });
 
-    test("Close event hides offcanvas", function (assert) {
-        assert.expect(1);
+    test("Events to show & hide offcanvas", function (assert) {
+        assert.expect(2);
+        $("#js-bootstrap-offcanvas").trigger("offcanvas.open");
+
+        assert.ok($("#js-bootstrap-offcanvas").hasClass("in"), "Off-Canvas should be visible");
+
         $("#js-bootstrap-offcanvas").trigger("offcanvas.close");
 
         assert.ok(!$("#js-bootstrap-offcanvas").hasClass("in"), "Off-Canvas should not be visible");