Merge pull request #10 from dgraph-io/jatin/fixIdBug

fix(GraphQL): Fix bug that got introduced in last commit , which doesn't allow string value in [ID] to be coerced to list.

validator/vars.go

@@ -84,7 +84,7 @@ func (v *varValidator) validateVarType(typ *ast.Type, val reflect.Value) (reflec
 			if typ.Name() == "ID" && val.Type().Name() != "string" {
 				val = val.Convert((reflect.ValueOf("string")).Type())
 				slc = append(slc, val.String())
-			} else if typ.Name() != "ID" {
+			} else {
 				slc = append(slc, val.Interface())
 			}
 			val = reflect.ValueOf(slc)
@@ -101,10 +101,10 @@ func (v *varValidator) validateVarType(typ *ast.Type, val reflect.Value) (reflec
 				field = field.Elem()
 			}
 			cval, err := v.validateVarType(typ.Elem, field)
-			if typ.Name() == "ID" && val.Type().Name() != "string" {
-				cval = cval.Convert((reflect.ValueOf("string")).Type())
-				slc = append(slc, cval.String())
-			} else if typ.Name() == "ID" {
+			if typ.Name() == "ID" {
+				if val.Type().Name() != "string" {
+					cval = cval.Convert((reflect.ValueOf("string")).Type())
+				}
 				slc = append(slc, cval.String())
 			}
 			if err != nil {

validator/vars_test.go

@@ -180,6 +180,16 @@ func TestValidateVars(t *testing.T) {
 			require.EqualValues(t, expected, vars["var"])
 		})
 
+		t.Run("single string value should be coerced to string array when required type is [ID]", func(t *testing.T) {
+			q := gqlparser.MustLoadQuery(schema, `query foo($var: [ID]) { idArrayArg(i: $var) }`)
+			vars, gerr := validator.VariableValues(schema, q.Operations.ForName(""), map[string]interface{}{
+				"var": "5",
+			})
+			require.Nil(t, gerr)
+			expected := []interface{}{"5"}
+			require.EqualValues(t, expected, vars["var"])
+		})
+
 		t.Run("int array should be coerced to string array when required type is [ID]", func(t *testing.T) {
 			q := gqlparser.MustLoadQuery(schema, `query foo($var: [ID]) { idArrayArg(i: $var) }`)
 			vars, gerr := validator.VariableValues(schema, q.Operations.ForName(""), map[string]interface{}{