opt(snapshot): use full table copy when streaming the entire data (#7870) #8736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
|
|
all-seeing-code
previously approved these changes
Mar 9, 2023
mangalaman93
force-pushed
the
aman/incr
branch
2 times, most recently
from
ade6f7f to
b5d2987
Compare
mangalaman93
force-pushed
the
aman/snap
branch
2 times, most recently
from
e05fe2b to
5ac38c5
Compare
mangalaman93
requested review from
sanjayk-github-dev,
harshil-goel and
joshua-goldstein
as code owners
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
force-pushed
the
aman/snap
branch
from
c3c050a to
eb7cc78
Compare
github-actions
bot
added
area/core
|
closing PR for now, keeping branch active |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.