Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Getters with Registry Warp Config #5344

Merged
merged 28 commits into from
Jan 31, 2025

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jan 30, 2025

Description

This PR replaces all non-AW managed Getters with Registry configs

Related issues

Backward compatibility

Yes

Testing

Tested with all

  • yarn tsx ./typescript/infra/scripts/check/check-deploy.ts -e mainnet3 -m warp --warpRouteId WETH/artela-base
  • yarn tsx ./scripts/warp-routes/generate-warp-config.ts -e mainnet3 --warpRouteId WETH/artela-base
  • yarn tsx ./typescript/infra/scripts/check/check-warp-deploy.ts -e mainnet3 -m warp
  • yarn test:unit

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: f29bac3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ltyu ltyu changed the base branch from main to ltyu/warp-config-test-optimization January 30, 2025 19:12
Base automatically changed from ltyu/warp-config-test-optimization to main January 30, 2025 19:14
@ltyu ltyu marked this pull request as ready for review January 30, 2025 19:14
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (57d22cf) to head (f29bac3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5344   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ltyu ltyu requested review from nambrot and xeno097 January 30, 2025 19:22
typescript/infra/config/warp.ts Outdated Show resolved Hide resolved
@ltyu ltyu enabled auto-merge January 31, 2025 16:42
@ltyu ltyu disabled auto-merge January 31, 2025 16:46
@ltyu ltyu enabled auto-merge January 31, 2025 16:56
@ltyu ltyu added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@ltyu ltyu added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 7641389 Jan 31, 2025
44 checks passed
@ltyu ltyu deleted the ltyu/replace-registry-warp-config branch January 31, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants