feat: Add new Sonic tokens, some SVM tooling drive-bys #5334
Conversation
tkporter
requested review from
paulbalaji,
Mo-Hussain and
daniel-savu
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5334 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
There was a problem hiding this comment.
lgtm but would also appreciate a second review from @daniel-savu on the rust improvements
| assert!( | ||
| self.description.is_some(), | ||
| "Description must be provided for token with name: {}", | ||
| self.name | ||
| ); | ||
| assert!( | ||
| self.image.is_some(), | ||
| "Image must be provided for token with name: {}", | ||
| self.name | ||
| ); |
There was a problem hiding this comment.
if these are mandatory, should their types have the Options removed?
| let metadata_response = reqwest::blocking::get(metadata_uri).unwrap(); | ||
| let metadata_contents: SplTokenOffchainMetadata = metadata_response | ||
| .json() | ||
| .expect("Failed to parse metadata JSON"); | ||
| metadata_contents.validate(); | ||
|
|
||
| // Ensure that the metadata contents match the provided token config. | ||
| assert_eq!(metadata_contents.name, synthetic.name, "Name mismatch"); |
Description
Drive-bys for the SVM tooling:
And adds the following tokens between Solana and Sonic: sSOL, USDStar, USDC, USDT, SONIC
Drive-by changes
Related issues
Backward compatibility
Testing