chore: merge Chainlight audit from Q3/Q4 2024 #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#4729) ### Description - implements `_outbound` and `_inbound` internal amount transforms for use in scaling warp routes - simplify `HypNativeScaled` implementation ### Backward compatibility Yes ### Testing Existing HypNative Scaled Unit Tests
…4673) ### Description - fixes misuse of aggregation hook funds for relaying messages by making sure msg.value is adequate and refunding if excess. ### Drive-by changes - None ### Related issues - related to #3437 ### Backward compatibility No, needs new deployments of aggregationHooks ### Testing Unit
### Description - Added onlySender to `RateLimitHook` to only allow a specific sender like a warp route to send messages through the hook. ### Drive-by changes None ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
### Description - Adopt scale across warp route contracts - Remove native scaled and support scaled everywhere - Update SDK deployer code to use new constructors ### Related issues - opens #5296 ### Backward compatibility SDK/CLI yes, core no ### Testing Unit Tests
yorhodes
requested review from
jmrossy,
ltyu,
paulbalaji,
tkporter and
aroralanuk
as code owners
🦋 Changeset detectedLatest commit: 228c3e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yorhodes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AggregationHook(fix(contracts): check for sufficient msgValue forAggregationHook#4673)RateLimitHook(fix(contracts): access control to prevent DOS onRateLimitHook#4757)