-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify registry override #5271
base: main
Are you sure you want to change the base?
Conversation
|
…ve override parameter
bb65215
to
ec25141
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5271 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending changeset addition
@@ -43,8 +42,7 @@ try { | |||
.scriptName('hyperlane') | |||
.option('log', logFormatCommandOption) | |||
.option('verbosity', logLevelCommandOption) | |||
.option('registry', registryUriCommandOption) | |||
.option('overrides', overrideRegistryUriCommandOption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that this is not used at all? I believe it actually is, so I would like to explicitly bump major versions for this and call this out in the changelog
Description
This PR includes two main improvements to the CLI's registry and parameter handling:
Removes the unused
--overrides
parameter from all warp command functions, which was previously only used for local testing purposes but is no longer needed.Enhances the registry handling by:
These changes simplify the codebase and make the registry configuration more flexible and explicit.
Related issues
#5267
Backward compatibility
Yes - These changes are backward compatible. The removal of the unused
--overrides
parameter doesn't affect functionality since it was not being actively used. The registry array structure maintains compatibility with existing registry configurations while adding support for multiple sources.Testing
Manual testing