feat: FuelVM support for Hyperlane #4861
Conversation
…structure/hyperlane-monorepo into feat/fuel-integration
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4861 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
| } | ||
|
|
||
| // Implement `EventDataTransformer` for `GasPaymentEvent` | ||
| impl EventDataTransformer for GasPaymentEvent { |
There was a problem hiding this comment.
These implementations all look identical, is it possible to make them more generic?
| // These conversions are the `From` implementations for converting the `Receipt` schema from the Fuels Rust SDK | ||
| // since we cannot implement `From` for our custom Recipt schema on the `fuels::tx::Receipt` directly. | ||
|
|
||
| pub fn generate_receipt(schema: Receipt) -> Result<FuelRecepit, ConversionError> { |
There was a problem hiding this comment.
kinda suprised there's no library for this code?
There was a problem hiding this comment.
nit: FuelRecepit spelling
| .into(), | ||
| ), | ||
| pc: schema | ||
| .pc |
There was a problem hiding this comment.
out of curosity, what's pc here - program counter?
| } | ||
|
|
||
| impl FuelInterchainGasPaymaster { | ||
| /// Create a new fuel validator announce contract |
| #[cynic::schema("fuel")] | ||
| mod schema {} | ||
|
|
||
| // The following macros and conversions are copied from the Fuels Rust SDK |
There was a problem hiding this comment.
can we not import this?
| .with_tx_policies(tx_policies) | ||
| .determine_missing_contracts(Some(3)) | ||
| .determine_missing_contracts(Some(10)) |
There was a problem hiding this comment.
can we make 10 a constant as max reattempts globally
| .tree() | ||
| .simulate(Execution::StateReadOnly) | ||
| .await | ||
| .map_err(ChainCommunicationError::from_other) |
| .count() | ||
| .simulate(Execution::StateReadOnly) | ||
| .await | ||
| .map_err(ChainCommunicationError::from_other) |
| @@ -81,6 +82,20 @@ impl Settings { | |||
| .ok_or_else(|| eyre!("No chain setup found for {domain}")) | |||
| } | |||
|
|
|||
| /// Check and warn if reorg period is set for FuelVM domains. | |||
| pub fn check_fuel_reorg(&self) { | |||
There was a problem hiding this comment.
not sure why you need this? we can just ignore the param
| pub async fn new( | ||
| conf: &ConnectionConf, | ||
| locator: ContractLocator<'_>, | ||
| mut wallet: WalletUnlocked, |
There was a problem hiding this comment.
Wallet (readonly) seems sufficient in a lot of these places or is WalletUnlocked just for consistency?
Description
Support FuelVM chains on the Hyperlane Protocol
Configurations for FuelTestnet and FuelIgnition
Backward compatibility
Yes
Testing
Contract repo E2E testing on local Fuel and EVM nodes
Contract repo E2E testing on Fuel Testnet and Base Sepolia
Notes
The configurations for the Fuel Testnet and Ignition are still WIP