Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update temoa_lib.py #15

Open
wants to merge 1 commit into
base: energysystem
Choose a base branch
from
Open

Update temoa_lib.py #15

wants to merge 1 commit into from

Conversation

ftong
Copy link

@ftong ftong commented Sep 6, 2013

Fan: The "l_total" should be replaced with "total".
Kevin: "It would appear that I forgot to
change that line when I made a variable name change last November:
c070fd4
This underlies the fact that at present we do not have a comprehensive test suite in place. (I suppose it's difficult to motivate one's self to do the necessary work on this front as it is inglorious and I cannot apply it as evidence for the degree!) "

Fan: The "l_total" should be replaced with "total".
Kevin: "It would appear that I forgot to 
change that line when I made a variable name change last November:   
hunteke@c070fd4 
This underlies the fact that at present we do not have a comprehensive test suite in place.  (I suppose it's difficult to motivate one's self to do the necessary work on this front as it is inglorious and I cannot apply it as evidence for the degree!) "
@hunteke
Copy link
Owner

hunteke commented Sep 6, 2013

The patch looks good. I just need a rewording of the commit message and then I can accept it. For the longer explanation, please see the Patches and Commits guidelines. Specifically, think about how someone would get quick mental context in, say, 1 year:

  • A subject line (<=50 characters). Perhaps something like "Forgotten variable rename during refactor"
  • Good that you reference the previous commit for context.
  • In this commit message context, the "test suite" comment is not relevant. That's better left for the forums.
  • A license line at the end.

@hunteke
Copy link
Owner

hunteke commented Sep 6, 2013

To change the commit message:

Locally:

$ git commit --amend
$ git push -f

Note that the latter command is only safe because no one else has pulled from your repository. See http://stackoverflow.com/questions/10728420/editing-the-git-commit-message-in-github for more information on that.

@ftong
Copy link
Author

ftong commented Sep 6, 2013

Thanks! I will keep a note of this. I previously edited the code manually
online which I guess is not 'safe'.

Fan

On Fri, Sep 6, 2013 at 10:23 AM, Kevin Hunter Kesling <
[email protected]> wrote:

To change the commit message:

Locally:
$ git commit --amend

$ git push -f

Note that the latter command is only safe because no one else has pulled
from your repository. See
http://stackoverflow.com/questions/10728420/editing-the-git-commit-message-in-githubfor more information on that.


Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-23943158
.

Fan Tong
First-year PhD student in Department of Engineering and Public Policy
Affiliated with the Center for Climate and Energy Decision
Makinghttp://cedm.epp.cmu.edu/
Carnegie Mellon University

@hunteke
Copy link
Owner

hunteke commented Sep 6, 2013

An alternative, if the git commit --amend and git push -f proves too much, you could also delete your fork, and refork for a fresh start. (Again, based on the fact that no one else has pulled from your fork.)

Let me know if I can be of any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants