-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add code owners #35528
base: main
Are you sure you want to change the base?
add code owners #35528
Conversation
Co-authored-by: Yih-Dar <[email protected]>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Pavel Iakubovskii <[email protected]>
… into add-code-owners
Co-authored-by: Alvaro Moran <[email protected]> Co-authored-by: Joao Gante <[email protected]> Co-authored-by: Matthew Douglas <[email protected]>
Being lazy to lessen my workload, could we automatically generate the mapping of models to owners, or manually generate it once and then add a CI test to ensure that new model additions have a matching CODEOWNERS line? This would mean that dispatch would happen automatically, instead of me manually doing it every time If you want, I can write a script to guess which category each model is, and then we can fix up that list afterwards |
For new model the issue is that we need to know if it's a vision model, language model or audio model etc. I can do it if you prefer 😉 |
Yes, I know! But we could just add a CI test that raises an error if the model isn't in CODEOWNERS, and then the PR author knows they need to add a line to assign it to the right person. I can add some comments in the file to tell them who to assign it to (or you can do it!) WDYT? |
What does this PR do?
Adds code owner to make sure reviewers are pinged accordingly!