Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code owners #35528

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

add code owners #35528

wants to merge 12 commits into from

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Jan 6, 2025

What does this PR do?

Adds code owner to make sure reviewers are pinged accordingly!

CODEOWNERS Show resolved Hide resolved
@ArthurZucker ArthurZucker changed the title add co owners add code owners Jan 6, 2025
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Alvaro Moran <[email protected]>
Co-authored-by: Joao Gante <[email protected]>
Co-authored-by: Matthew Douglas <[email protected]>
@Rocketknight1
Copy link
Member

Being lazy to lessen my workload, could we automatically generate the mapping of models to owners, or manually generate it once and then add a CI test to ensure that new model additions have a matching CODEOWNERS line? This would mean that dispatch would happen automatically, instead of me manually doing it every time

If you want, I can write a script to guess which category each model is, and then we can fix up that list afterwards

@ArthurZucker
Copy link
Collaborator Author

For new model the issue is that we need to know if it's a vision model, language model or audio model etc. I can do it if you prefer 😉

@Rocketknight1
Copy link
Member

Rocketknight1 commented Jan 7, 2025

Yes, I know! But we could just add a CI test that raises an error if the model isn't in CODEOWNERS, and then the PR author knows they need to add a line to assign it to the right person. I can add some comments in the file to tell them who to assign it to (or you can do it!) WDYT?

@ArthurZucker ArthurZucker marked this pull request as ready for review January 8, 2025 15:39
CODEOWNERS Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants