Update the dependency version to fix the CI #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrien <[email protected]> Co-authored-by: Guillaume LEGENDRE <[email protected]>
Signed-off-by: Adrien <[email protected]>
Signed-off-by: Adrien <[email protected]>
Signed-off-by: Adrien <[email protected]>
Signed-off-by: Adrien <[email protected]>
|
The dependencies were updated on another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
related to #295
https://github.com/huggingface/text-embeddings-inference/actions/runs/11686554315/job/32542586602?pr=295
I found CI was failing due to a version mismatch between ndarray and ort crates. comb of ndarray 0.15.6 and ort 2.0.0-rc4 is fine, but, in the CI pipeline, it tried to use 2.0.0-rc8, not rc4, and 2.0.0-rc8 requires ndarray 0.16.1. so, I just explicitly updated the ndarray crate version to 0.16.1 along with ort to 2.0.0-rc8.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@OlivierDehaene OR @Narsil