Fix T_co import bug
#484
Merged
Fix T_co import bug
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi! |
Thanks for the review! I've just fixed the styling. |
clefourrier
approved these changes
Jan 7, 2025
|
I think this is enough to make lighteval work with torch 2.5.1, allowing us to revert #369. Sorry if I missed it in the docs; do you have canonical instructions on how and in which environment to run all tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug (
ImportError) when trying to importT_cowithtorch==2.5.0or newer. It appears that the variableT_cohas been renamed to_T_cointorch. Please see https://github.com/pytorch/pytorch/blob/ee1b6804381c57161c477caa380a840a84167676/torch/utils/data/distributed.py#L10 and https://github.com/pytorch/pytorch/blob/a1ae8fadc709f7c18788f8828ee3166f96245bec/torch/utils/data/distributed.py#L13