Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add asian language support to CorpusLevelTranslationMetric #479

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add asian language support to CorpusLevelTranslationMetric #479

wants to merge 4 commits into from

Conversation

ryan-minato
Copy link
Contributor

finish #478

NathanHB
NathanHB approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NathanHB
Copy link
Member

NathanHB commented Jan 7, 2025

Hi ! You just need to fix the tests and this should be good :)

@ryan-minato
Copy link
Contributor Author

Hi ! You just need to fix the tests and this should be good :)

I forgot to import Literal, but I've just fixed it. The pre-commit checks have already passed on my machine.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanHB NathanHB NathanHB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryan-minato @NathanHB @HuggingFaceDocBuilderDev