Added cache for openai models. #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't test this one so it will wait for Nathan to come back - however, you'll also need to add diskcache to our requirements, and I'm not sure we want to expand them so much |
|
In case you don't want to add diskcache to your requirements, what alternative do you see? Or does that mean that we don't do any caching? |
|
Thanks for the solutions ! I will be reviewing this tomorrow :) |
|
Not sure this is needed anymore as we have litellm to cache model's responses |
|
Yes, if we can use litellm for everything, then we don't need it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue 414 by adding a diskcache to the openai backend.