Fix apply_chat_template function for dpo and unknown task
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks a lot for the fix @alvarobartt - this looks great 🤗 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to whoever is reading this! 🤗
Description
This PR solves an issue with the error message when the
taskinalignment.data.apply_chat_templatewas not being recognised as it was incorrect, and also moved some lines under thedpotask.Besides that, also some duplicated
# coding=utf-8lines have been removed.