Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNIT] Final review of Unit 2.1 on smolagents - release 25/2/25 #216

Merged
merged 55 commits into from
Feb 25, 2025

Conversation

burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Feb 21, 2025

transferred from >> #195

This PR is to review the final changes for the unit on the smolagents library.

Prose to review @pcuenca @simoninithomas @davidberenstein1957

  • units/en/unit2/smolagents/code_agents.md
  • units/en/unit2/smolagents/introduction.md
  • units/en/unit2/smolagents/multi_agent_systems.md
  • units/en/unit2/smolagents/retrieval_agents.md
  • units/en/unit2/smolagents/tool_calling_agents.md
  • units/en/unit2/smolagents/tools.md
  • units/en/unit2/smolagents/why_use_smolagents.md

Outstanding work for other PRs

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@simoninithomas
Copy link
Member

@burtenshaw and @sergiopaniego for the notebooks, there's two small things to update:

  1. If we can add for each notebook this
Screenshot 2025-02-21 at 15 46 32

Why I say that is that a 10% part of the trafic of Deep RL course come from people who found the notebook online. What I did in DRLC is adding the link of the course and the section.

  1. For each section when we start to work on code, even if we put the button on top of the section open with colab. We should add something like this:

-> You can try the code yourself using our colab notebook 👉 link

WDYT 🤔

@simoninithomas
Copy link
Member

  1. Where we want to place the notebooks, we can instead put them on the agent-course organization: https://huggingface.co/agents-course/notebooks

This way it generates a "open in colab"

But tbh I don't have strong opinion on this 3rd point

Screenshot 2025-02-21 at 15 51 55

@sergiopaniego
Copy link
Collaborator

Thanks for the comments @simoninithomas!
I'm already addressing these comments in #217
The reasoning behind adding the banner on the notebooks is super clever! I hadn’t thought of that. Definitely a must-add 😄

By the way, I love the intro diagram you created! Just a small note, it says "Agent Course". Should it be "Agents Course" instead?

Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Aymeric <[email protected]>
@burtenshaw burtenshaw merged commit 6fac315 into main Feb 25, 2025
1 check passed
@burtenshaw burtenshaw deleted the unit_2_1_smolagents branch February 25, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants