Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow network-3.2 #6

Merged
merged 1 commit into from
Aug 9, 2024
Merged

allow network-3.2 #6

merged 1 commit into from
Aug 9, 2024

Conversation

ysangkok
Copy link

@ysangkok ysangkok commented Jul 9, 2024

Hi Ganesh. This was tested using cabal build -w ghc-9.8.2 -c 'network>=3.2'. I think a revision would be sufficient since there are no source changes.

@andreasabel
Copy link

@hsenag See:

@ysangkok wrote:

This was tested using cabal build -w ghc-9.8.2 -c 'network>=3.2'.

This project does not have CI. Did you also test functionality (beyond buildability)?

@ysangkok
Copy link
Author

@andreasabel Yes, the following works:

 % cabal run httpd-shed-test -f buildExamples -w ghc-9.10.1 -c 'network>=3.2'
Resolving dependencies...
Build profile: -w ghc-9.10.1 -O1
In order, the following will be built (use -v for more details):
 - httpd-shed-0.4.1.2 (lib) (configuration changed)
 - httpd-shed-0.4.1.2 (exe:httpd-shed-test) (first run)
Configuring library for httpd-shed-0.4.1.2...
Preprocessing library for httpd-shed-0.4.1.2...
Building library for httpd-shed-0.4.1.2...
Configuring executable 'httpd-shed-test' for httpd-shed-0.4.1.2...
Preprocessing executable 'httpd-shed-test' for httpd-shed-0.4.1.2...
Building executable 'httpd-shed-test' for httpd-shed-0.4.1.2...
[1 of 1] Compiling Main             ( test/Main.hs, /home/janus/flipstone/httpd-shed/dist-newstyle/build/x86_64-linux/ghc-9.10.1/httpd-shed-0.4.1.2/x/httpd-shed-test/build/httpd-shed-test/httpd-shed-test-tmp/Main.o )
[2 of 2] Linking /home/janus/flipstone/httpd-shed/dist-newstyle/build/x86_64-linux/ghc-9.10.1/httpd-shed-0.4.1.2/x/httpd-shed-test/build/httpd-shed-test/httpd-shed-test
Request {reqMethod = "GET", reqURI = /, reqHeaders = [("Host","localhost:8091\r"),("User-Agent","curl/7.88.1\r"),("Accept","*/*\r")], reqBody = ""}
""
[]

The last lines were generated by:

% lsof -i4
httpd-she 150403 janus    8u  IPv4 669466      0t0  TCP *:8091 (LISTEN)
% curl localhost:8091
<root dir>

Not sure what else to test. Looking at the network-3.2.0.0 changelog, it seems unlikely that anything broke if compilation succeeded and this basic test worked.

@hsenag
Copy link
Owner

hsenag commented Aug 9, 2024

Sorry for the delay picking this up - I've run the HTTP test suite which is the main use of httpd-shed that I know of and it passes fine. I'll get a hackage revision made as well.

@hsenag hsenag merged commit 9abb2c1 into hsenag:master Aug 9, 2024
@ysangkok ysangkok deleted the network-bump branch August 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants