Update to sdk with latest changes #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slogsdon
suggested changes
Jun 19, 2020
classes/admin/class-submenu.php
Outdated
| $config->versionNumber = '1510'; | ||
| $config->developerId = '002914'; | ||
| return $config; | ||
| $config->serviceUrl = "https://cert.api2.heartlandportico.com"; |
There was a problem hiding this comment.
We need to account for both sandbox and production environments. As is, this will only send requests to sandbox, even if production credentials are configured.
| @@ -555,7 +572,7 @@ protected function listTransactionsConvertExceptions($item) | |||
| return $item; | |||
| } | |||
|
|
|||
| if (!empty($item->exceptions->hpsException)) { | |||
| if (!empty($item->exceptions->Exceptions)) { | |||
There was a problem hiding this comment.
There's no direct mapping from the old SDK to the new one for this. We may have to reinvision how this operates with the new SDK.
classes/admin/class-submenu.php
Outdated
| ) { | ||
| $builder = $service->reverse(); | ||
| $builder = Transaction::fromId($transaction->transactionId) |
There was a problem hiding this comment.
For gift transactions, we need to supply the PaymentMethodType::GIFT as the second parameter to Transaction::fromId in order for the request type to be mapped correctly for any non-credit card requests.
There was a problem hiding this comment.
This would apply to eCheck/ACH transactions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.