Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default configuration #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MikeGoldsmith
Copy link

Which problem is this PR solving?

When creating pipelines based on HPSF, it's important to start with a simple and valid configuration. This PR adds a configuration that be used as a basis for initial pipeline configurations.

Short description of the changes

  • Adds a simple default valid configuration that includes a simple Refinery configuration with a deterministic sampler

@MikeGoldsmith MikeGoldsmith added the enhancement New feature or request label Jan 6, 2025
@MikeGoldsmith MikeGoldsmith self-assigned this Jan 6, 2025
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner January 6, 2025 11:07
@kentquirk
Copy link
Contributor

Let's talk about this in sync. There are two issues:

  • This isn't actually a valid configuration, because it doesn't have importers or exporters
  • The current plan is to have multiple starting templates to choose from when you create a new configuration; we shouldn't need to define them in Go code because they'll be stored as YAML in a database.

I hear from this that we need a little more explanation of how this is all going to fit together. I'll share some docs.

Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long term plan here is that users will choose from one of several templates to start, and so we won't be using a default configuration built into the go code at all -- we'll be fetching something from a database. But it seems like it might be useful to have this for now.

So as long as we understand that this is likely just going to go away, there's no harm in having it until we build that database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants